microsoft / microsoft/Detours

detours crash on DetourAttach

Open
#145 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
6.4k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Hi,

I have used detours on 2 projects. In the first project work fine.

The second project crash always when I use DetourAttach:

// This row cause crash
DetourAttach(&(LPVOID&)AddressOfHookDamageFunction, &HookDamageSub);

The second project is a 90% copy of the first project.

AddressOfHookDamageFunction = 0x72DD81 (this is stored in (ffback.ini)

Becouse is very hard understand why this happen. I attach the entere project:
BattleZone CC.zip

just open:

dllmain.cpp

goto "Init_Detour" and you find the line with DetourAttach.

To be honest I have no idea about this situation and I not sure if this is a bug,

Can you please verify ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the attached BattleZone CC project and locate dllmain.cpp, then find the Init_Detour entry point and reproduce the crash at DetourAttach. Compare this project with the working copy to identify a reproducible cause; done means the cause is explained and the failing project no longer crashes at that call.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
devtools, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.