microsoft / microsoft/DefinitelyTyped-tools

Transitive triple-slash dependencies aren't tested

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
423
Forks
237
Avg merge
18h 18m
Merged PRs (30d)
11

Description

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45845 should have failed when it tested pouchdb-core (and its dependents), but it didn't even test those.

The dependency chain is pouchdb-core -> node-fetch -> node. All references are triple-slash references.

To repro this, make a change in node. Then check whether the "Testing NNN dependent packages:" line includes pouchdb-core.

Expected: It does.
Actual: It doesn't.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by making a change in the node package and checking the "Testing NNN dependent packages:" output. Trace the dependent-package discovery logic for triple-slash references and verify that the node-fetch to pouchdb-core chain is followed. Done means the output includes pouchdb-core and its dependents.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.