microsoft / microsoft/DefinitelyTyped-tools

test-all sometimes tests packages more than once

Open
#656 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
423
Forks
237
Avg merge
18h 18m
Merged PRs (30d)
11

Description

When running npm run test-all in the DT repo I sometimes see packages being tested twice. Oftentimes locally when making changes to React but now I also caught one in CI. Notice how it starts cavy, cavy fails and then it starts cavy again:

Screenshot_from_2023-03-26_20-29-35

-- https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/4524856076/jobs/7968956281?pr=64896#step:6:796

Originally reported in https://discord.com/channels/508357248330760243/757992230077333655/1089617477274718208

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running npm run test-all in the DefinitelyTyped-tools repository and compare the output when a package such as cavy is tested. Then inspect the linked CI job, especially the test step, to determine why a package can be scheduled twice. Done means each package is tested once per run, including when a test fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
ci-cd, testing-qa, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.