microsoft / microsoft/DefinitelyTyped-tools
Standalone notNeededPackage.json entry passes CI
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 423
- Forks
- 237
- Avg merge
- 18h 18m
- Merged PRs (30d)
- 11
Description
If you edit only notNeededPackages.json to add one entry, but don't delete anything from the filesystem, CI passes when it should actually fail. Entries in notNeededPackages.json imply that their associated types on DT have been deleted.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the CI validation that reads notNeededPackages.json and compares its entries with the filesystem. Reproduce a change that adds one standalone entry without deleting types, then make the check fail for that case and confirm CI still passes for valid deletions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- ci-cd, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100