microsoft / microsoft/DefinitelyTyped-tools
Cannot remove prerelease version of package
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 423
- Forks
- 237
- Avg merge
- 18h 18m
- Merged PRs (30d)
- 11
Description
I've created PR here DefinitelyTyped/DefinitelyTyped#41418, which fails CI build check as the package version is prelease one (previously it was tagged as alpha, now as rc): 1.0.0-rc.2.
The check fails because of strict version check, which does not coerce prelease versions as in https://github.com/npm/node-semver/blob/70d9fb3f1c128227a3cd911867edb07a54260cad/classes/semver.js
Is that version check outcome expected (I'd close the issue) or should it be somehow addressed?
Thanks!
Somehow similar, already tracked issue:
https://github.com/microsoft/types-publisher/issues/696
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing DefinitelyTyped/DefinitelyTyped#41418 and the strict version check that rejects 1.0.0-rc.2. Compare its outcome with the linked node-semver behavior and the related issue #696. Done means documenting whether the rejection is expected or making the check handle the prerelease version so the CI build passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js
- Domain
- ci-cd, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100