microsoft / microsoft/DefinitelyTyped-tools

Publication notification comment fails intermittently

Open
#36 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

publisher
Dominant language
TypeScript
Stars
423
Forks
237
Avg merge
18h 18m
Merged PRs (30d)
11

Description

I suspect throttling or just performance hiccups on github's end. There's no retry logic in the multiple calls.

A run looks like this. Notice that is-number-like, redux-router and quick-hash work fine, but turbostatus and vigour-ua don't log after "Requesting from github".

Publishing is-number-like...
Tag @types/is-number-like@1.0.0 as ["ts2.0","ts2.1","ts2.2","ts2.3","ts2.4","ts2.5","ts2.6","ts2.7","ts2.8","ts2.9","ts3.0","ts3.1","ts3.2","ts3.3","ts3.4","ts3.5","latest"]
Requesting from github: repos/DefinitelyTyped/DefinitelyTyped/commits?path=types%2fis-number-like
Found related commits; hash: b1ca3864162b5f3ea4625a75f7798368b4d269a4
Requesting from github: search/issues?q=is:pr%20is:merged%20b1ca3864162b5f3ea4625a75f7798368b4d269a4
Latest PR: 35629
Requesting from github: repos/DefinitelyTyped/DefinitelyTyped/pulls/35629
Current date is Wed May 22 2019 16:14:39 GMT+0000 (Coordinated Universal Time)
  Merge date is Wed May 22 2019 16:07:09 GMT+0000 (Coordinated Universal Time)
I just published [`@types/is-number-like@1.0.0` to npm](https://www.npmjs.com/package/@types/is-number-like).
Posting to github at repos/DefinitelyTyped/DefinitelyTyped/issues/35629/comments: {"body":"I just published [`@types/is-number-like@1.0.0` to npm](https://www.npmjs.com/package/@types/is-number-like)."}
From github: {"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/494871485","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/35629#issuecomment-494871485","issue
Done logging latency
Publishing quick-hash...
Tag @types/quick-hash@1.0.0 as ["ts2.0","ts2.1","ts2.2","ts2.3","ts2.4","ts2.5","ts2.6","ts2.7","ts2.8","ts2.9","ts3.0","ts3.1","ts3.2","ts3.3","ts3.4","ts3.5","latest"]
Requesting from github: repos/DefinitelyTyped/DefinitelyTyped/commits?path=types%2fquick-hash
Found related commits; hash: b1ca3864162b5f3ea4625a75f7798368b4d269a4
Requesting from github: search/issues?q=is:pr%20is:merged%20b1ca3864162b5f3ea4625a75f7798368b4d269a4
Latest PR: 35629
Requesting from github: repos/DefinitelyTyped/DefinitelyTyped/pulls/35629
Current date is Wed May 22 2019 16:15:00 GMT+0000 (Coordinated Universal Time)
  Merge date is Wed May 22 2019 16:07:09 GMT+0000 (Coordinated Universal Time)
I just published [`@types/quick-hash@1.0.0` to npm](https://www.npmjs.com/package/@types/quick-hash).
Posting to github at repos/DefinitelyTyped/DefinitelyTyped/issues/35629/comments: {"body":"I just published [`@types/quick-hash@1.0.0` to npm](https://www.npmjs.com/package/@types/quick-hash)."}
From github: {"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/494871632","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/35629#issuecomment-494871632","issue
Done logging latency
Publishing redux-first-router...
Tag @types/redux-first-router@2.1.3 as ["ts2.4","ts2.5","ts2.6","ts2.7","ts2.8","ts2.9","ts3.0","ts3.1","ts3.2","ts3.3","ts3.4","ts3.5","latest"]
Requesting from github: repos/DefinitelyTyped/DefinitelyTyped/commits?path=types%2fredux-first-router
Found related commits; hash: 083ba71eab7e16270bcb124954370f08f84f8b33
Requesting from github: search/issues?q=is:pr%20is:merged%20083ba71eab7e16270bcb124954370f08f84f8b33
Latest PR: 35500
Requesting from github: repos/DefinitelyTyped/DefinitelyTyped/pulls/35500
Current date is Wed May 22 2019 16:15:25 GMT+0000 (Coordinated Universal Time)
  Merge date is Wed May 22 2019 16:11:27 GMT+0000 (Coordinated Universal Time)
I just published [`@types/redux-first-router@2.1.3` to npm](https://www.npmjs.com/package/@types/redux-first-router).
Posting to github at repos/DefinitelyTyped/DefinitelyTyped/issues/35500/comments: {"body":"I just published [`@types/redux-first-router@2.1.3` to npm](https://www.npmjs.com/package/@types/redux-first-router)."}
From github: {"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/494871788","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/35500#issuecomment-494871788","issue
Done logging latency
Publishing turbostatus...
Tag @types/turbostatus@2.4.0 as ["ts2.0","ts2.1","ts2.2","ts2.3","ts2.4","ts2.5","ts2.6","ts2.7","ts2.8","ts2.9","ts3.0","ts3.1","ts3.2","ts3.3","ts3.4","ts3.5","latest"]
Requesting from github: repos/DefinitelyTyped/DefinitelyTyped/commits?path=types%2fturbostatus
Publishing vigour-ua...
Tag @types/vigour-ua@4.0.0 as ["ts2.2","ts2.3","ts2.4","ts2.5","ts2.6","ts2.7","ts2.8","ts2.9","ts3.0","ts3.1","ts3.2","ts3.3","ts3.4","ts3.5","latest"]
Requesting from github: repos/DefinitelyTyped/DefinitelyTyped/commits?path=types%2fvigour-ua
Checking for cache file at D:\home\site\wwwroot\bin\lib/../../cache/npmInfo.json...
Reading cache file...
Done!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the publication notification flow and the GitHub API calls shown in the issue, starting with the calls that stop after “Requesting from github.” Verify the behavior with repeated publication runs; done means transient GitHub failures are retried and publication comments complete reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.