microsoft / microsoft/DefinitelyTyped-tools
header-parser: add reviewer
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 423
- Forks
- 237
- Avg merge
- 18h 18m
- Merged PRs (30d)
- 11
Description
Related to DefinitelyTyped/dt-mergebot#248: when this was discussed, the conclusion was that there's no good way to guess when an owner approval is required, and therefore the header should be extended with an optional field for the required approval level. The value should be owner or maintainer.
(Maybe for completeness allow other too? The parser can just ignore the actual value, and leave that for the mergebot to decide what to do with it.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the header-parser component and read the discussion in DefinitelyTyped/dt-mergebot#248 for the approval-level context. Trace how header fields are parsed and determine where the optional field is represented. Done means headers can include the proposed approval-level value without the parser trying to interpret it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100