microsoft / microsoft/DefinitelyTyped-tools
Testing changes in playground doesn't work
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 423
- Forks
- 237
- Avg merge
- 18h 18m
- Merged PRs (30d)
- 11
Description
When a PR to DefinitelyTyped is opened, the mergebot posts a comment You can test the changes of this PR in the Playground. When the link to playground is opened and user agrees to install the playground-dt-review plugin, the plugin makes a request to https://dtmergebot.azurewebsites.net/api/Playground-Info?number=${prNum}&code=<something>. This request fails, because dtmergebot.azurewebsites.net does not exist. There is a PR (https://github.com/orta/playground-dt-review/pull/6) to change the URL to dtmergebot2, but it also doesn't exist.
According to the configuration, up-to-date domain is dtmergebot3.azurewebsites.net, but if I modify the plugin code and change the domain, server responds with 403 Ip Forbidden.
Could you either fix the API access (and somehow get @orta to update the plugin)? The alternative is removing entirely this broken functionality and the message from mergebot:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/mergebot/src/compute-pr-actions.ts and .github/workflows/deploy.yml, then inspect the linked playground-dt-review plugin and its Playground-Info request. Determine whether the deployed API can be accessed or whether the broken Playground message should be removed; done means the selected behavior works without the current failing request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, typescript
- Domain
- api, cloud, devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100