microsoft / microsoft/DefinitelyTyped-tools
mergebot "unreviewed" handling for unblessed PRs
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 423
- Forks
- 237
- Avg merge
- 18h 18m
- Merged PRs (30d)
- 11
Description
For PRs that require maintainer approval, owner approval does not prevent mergebot from marking a PR as "unreviewed" if still waiting on a DT maintainer.
This isn't the end of the world from the perspective of visibility on the DT board, but the notification logic is the same, and comments a notification to every package owner despite the PR already having been reviewed. This is an annoyance for critical package maintainers, and confusing for contributors.
It'd be an improvement if this scenario were handled separately.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing mergebot's "unreviewed" handling for unblessed PRs and the shared notification path described in the report. Compare PRs with owner approval that still await DT maintainer approval, then define separate handling so reviewed PRs no longer notify every package owner; confirm the board visibility and notification behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100