microsoft / microsoft/DacFx

Deploy loads all dll's in dacpac directory. Never unloads them.

Open
#512 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug dacfx.projects
Dominant language
C#
Stars
460
Forks
29
Avg merge
4d 9h
Merged PRs (30d)
7

Description

  • SqlPackage or DacFx Version: DacFx 162.4.92
  • .NET Framework (Windows-only) or .NET Core: Net 8.0
  • Environment (local platform and source/target platforms): Windows 10, ran locally.

Steps to Reproduce:

  1. Build a SqlProj file, so it creates a dacpac (it also creates a dll).
  2. Put some random dll's in the directory where the dacpac resides.
  3. Deploy the dacpac
  4. When the deploying has finished try deleting any of the dll's in the directory

Note: You can see that all the dll's in that directory has been loaded into the process using Process Explorer.

Did this occur in prior versions? If not - which version(s) did it work in?
Unsure

Expected behaviour
After deployment is complete, all dll's loaded by the deployment should be unloaded and you should be able to delete any file in the dacpac directory without having to restart the program.

Potentially bad work around
Delete all dll's in the directory before calling Deploy.
(Is the dll produced by the DacPac build actually used ? Deploy still works without it)

thanks
Mike

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on Windows 10 with DacFx 162.4.92 and .NET 8.0: deploy a dacpac containing extra DLLs, then attempt to delete them. Trace the SqlPackage or DacFx Deploy path and verify that every DLL loaded from the dacpac directory can be deleted after deployment completes.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, sql
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.