microsoft / microsoft/CsWinRT

Perf: IIterator<>, IBindableIterator should use random access if available

Open
#186 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement performance
Dominant language
C#
Stars
665
Forks
134
Avg merge
1d 3h
Merged PRs (30d)
32

Description

The IIterable<> and IBindableIterable projections should have special implementations of IIterator IBindableIterator that use random access if available, by probing for IVector<>, IVectorView<>. This would reduce the number of vcalls from two (MoveNext, Current) to one (GetAt) while iterating over a collection.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the projections for IIterable<> and IBindableIterable and their IIterator and IBindableIterator implementations. Inspect how they currently handle MoveNext and Current, then trace the available IVector<> and IVectorView<> interfaces. Done means random-access collections use GetAt while preserving iteration behavior and reducing the vcall count.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop, devtools, performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.