microsoft / microsoft/CsWin32

Recognize `Item` methods as indexers

Open
#824 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

Consider this interface in the metadata:

[Windows.Win32.Interop.Guid(2722677164u, 50840, 19974, 158, 92, 213, 127, 119, 199, 230, 71)]
[SupportedOSPlatform("windows5.1.2600")]
public interface IInkCursors : IDispatch
{
	[SpecialName]
	unsafe HRESULT get_Count([Out] int* Count);

	[SpecialName]
	unsafe HRESULT get__NewEnum([Out] IUnknown* _NewEnum);

	unsafe HRESULT Item([In] int Index, [Out] IInkCursor* Cursor);
}

Ideally, the Item method would be recognized and be exposed as an indexer rather than a method.
Consider getter/setter/both cases.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the IInkCursors metadata example and tracing the source generator's handling of methods named Item. Identify the relevant generator entry point and tests, then verify that getter-only, setter-only, and getter/setter Item methods are exposed as indexers rather than ordinary methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.