Consider returning null SafeHandle when invalid handle is produced
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C#
- Stars
- 2.5k
- Forks
- 124
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 9
Description
When an invalid handle value is produced from a win32 API, we should consider returning a null SafeHandle instead of a new one with an invalid handle in it.
We should probably do this at the same time as adding nullable ref annotations.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how Win32 API results are converted into SafeHandle instances, then review how nullable reference annotations would affect those generated results. Define which invalid handle values should produce null and verify the generated signatures and behavior for representative invalid-handle cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100