microsoft / microsoft/CsWin32

Analyzer to flag ignoring error return values

Open
#798 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

analyzers enhancement
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

It is a very common bug for code to invoke extern methods or COM interface methods and disregard the error code that is returned from those methods. An analyzer that catches this would be immensely useful to many applications.

Error codes include:

  • WIN32_ERROR
  • HRESULT
  • NTSTATUS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the project's C# source-generator and diagnostic infrastructure, then determine how ignored WIN32_ERROR, HRESULT, and NTSTATUS return values should be identified and tested; done requires agreed behavior and coverage for those cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.