microsoft / microsoft/CsWin32

IVssBackupComponents is not generated correctly

Open
#1,798 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

Actual behavior

https://learn.microsoft.com/en-us/windows/win32/api/vsbackup/nf-vsbackup-ivssbackupcomponents-addtosnapshotset
[in] VSS_PWSZ pwszVolumeName, is generated as an ushort instead of a VSS_PWSZ string (PCWSTR).

Also SetContext can use VSS_SNAPSHOT_CONTEXT as parameter rather than int.

Context

Expected behavior

Generate correct signature.

Repro steps

  1. NativeMethods.txt content:
IVssBackupComponents
  1. NativeMethods.json content (if present):
  1. Any of your own code that should be shared?
Context
  • CsWin32 version: latest
  • Target Framework: .net10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with a NativeMethods.txt containing IVssBackupComponents and inspect the generated signatures for AddToSnapshotSet and SetContext. Compare the generated parameter types with the VSS API documentation and the linked win32metadata context; done means the volume name uses the correct VSS_PWSZ string type and SetContext uses VSS_SNAPSHOT_CONTEXT.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.