microsoft / microsoft/CsWin32

`IURL_INVOKECOMMAND_FLAGS` doesn't have `[Flags]` specified.

Open
#1,661 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

Actual behavior

I'm pretty sure this should be a bitfield.

namespace Windows.Win32
{
	namespace UI.Shell
	{
		[global::System.CodeDom.Compiler.GeneratedCode("Microsoft.Windows.CsWin32", "0.3.269+368685089b.RR")]
		internal enum IURL_INVOKECOMMAND_FLAGS
		{
			IURL_INVOKECOMMAND_FL_ALLOW_UI = 1,
			IURL_INVOKECOMMAND_FL_USE_DEFAULT_VERB = 2,
			IURL_INVOKECOMMAND_FL_DDEWAIT = 4,
			IURL_INVOKECOMMAND_FL_ASYNCOK = 8,
			IURL_INVOKECOMMAND_FL_LOG_USAGE = 16,
		}
	}
}

Expected behavior

That it be a bitfield.

Repro steps

  1. NativeMethods.txt content:
IURL_INVOKECOMMAND_FLAGS
  1. NativeMethods.json content (if present): N/A

  2. Any of your own code that should be shared? N/A

Context
  • CsWin32 version: 0.3.269
  • Win32Metadata version (if explicitly set by project): N/A
  • Target Framework: net472
  • LangVersion (if explicitly set by project): N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the generation path for the IURL_INVOKECOMMAND_FLAGS request reproduced through NativeMethods.txt, and compare it with the generated enum shown in the issue. Verify the generated declaration represents the values as a bitfield and add or run the relevant generator test if one exists; done means the repro produces an enum usable for flag combinations.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.