microsoft / microsoft/CsWin32

Friendly overload for `MsiDatabaseOpenView()` is not appropriate

Open
#1,655 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

Actual behavior

The signature for the friendly overload is MsiDatabaseOpenView(SafeHandle hDatabase, string szQuery, ref MSIHANDLE phView), which doesn't match the docs as it's an out parameter, and the ref'd parameter cannot be used with MsiViewExecute() without creating my own SafeHandle or using the bare P/Invoke.

Expected behavior

The phView should be an out parameter and should typed as MsiCloseHandleSafeHandle.

Repro steps

  1. NativeMethods.txt content:
MsiDatabaseOpenView
  1. NativeMethods.json content (if present): N/A

  2. Any of your own code that should be shared? N/A

Context
  • CsWin32 version: 0.3.269
  • Win32Metadata version (if explicitly set by project): N/A
  • Target Framework: net472
  • LangVersion (if explicitly set by project): N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the NativeMethods.txt repro containing MsiDatabaseOpenView and inspect the generated friendly overload and related handle typing. Done means the overload exposes phView as an out MsiCloseHandleSafeHandle that can be passed to MsiViewExecute without a custom handle or bare P/Invoke.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.