Friendly overload for `MsiDatabaseOpenView()` is not appropriate
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.5k
- Forks
- 124
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 9
Description
Actual behavior
The signature for the friendly overload is MsiDatabaseOpenView(SafeHandle hDatabase, string szQuery, ref MSIHANDLE phView), which doesn't match the docs as it's an out parameter, and the ref'd parameter cannot be used with MsiViewExecute() without creating my own SafeHandle or using the bare P/Invoke.
Expected behavior
The phView should be an out parameter and should typed as MsiCloseHandleSafeHandle.
Repro steps
NativeMethods.txtcontent:
MsiDatabaseOpenView
-
NativeMethods.jsoncontent (if present): N/A -
Any of your own code that should be shared? N/A
Context
- CsWin32 version: 0.3.269
- Win32Metadata version (if explicitly set by project): N/A
- Target Framework: net472
LangVersion(if explicitly set by project): N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the NativeMethods.txt repro containing MsiDatabaseOpenView and inspect the generated friendly overload and related handle typing. Done means the overload exposes phView as an out MsiCloseHandleSafeHandle that can be passed to MsiViewExecute without a custom handle or bare P/Invoke.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100