microsoft / microsoft/CsWin32

IPortableDevice types being generated with in keywords

Open
#1,635 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

Actual behavior

Some PortableDevice related COM interfaces are generated with inaccurate method signatures. Everything still works, but I don't think this is correctly generated. For example:

internal interface IPortableDevicePropVariantCollection
{
    void GetCount(in uint pcElems);
    ...
    void GetAt(uint dwIndex, in winmdroot.System.Com.StructuredStorage.PROPVARIANT pValue);
}

I've found the same behavior on IPortableDevicePropVariantCollection, IPortableDeviceKeyCollection, IPortableDeviceValues, and IPortableDeviceValuesCollection.

Expected behavior

For all of those methods, I would expect the data to be returned to me to use an out parameter rather than an in parameter.

Repro steps

  1. NativeMethods.txt content:
IPortableDevice
Context
  • CsWin32 version: 0.3.269-beta
  • Target Framework: net9.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using a NativeMethods.txt file containing IPortableDevice and inspect the generated declarations for IPortableDevicePropVariantCollection, IPortableDeviceKeyCollection, IPortableDeviceValues, and IPortableDeviceValuesCollection. Trace how their method signatures are generated, then verify that returned data uses out parameters rather than in parameters.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.