microsoft / microsoft/CsWin32

The generated Marshaller has mistaken namespace

Open
#1,632 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

Actual behavior

When CsWin32RunAsBuildTask is true, the generated Marshaller has mistaken namespace:

[DebuggerDisplay("{Value}"),NativeMarshalling(typeof(global::Java..InteropServices.JBooleanMarshaller))]
[global::System.CodeDom.Compiler.GeneratedCode("Microsoft.Windows.CsWin32", "0.3.269+368685089b.RR")]
internal readonly partial struct JBoolean : IEquatable<JBoolean>;

Image

namespace .InteropServices
{
    [global::System.Runtime.InteropServices.Marshalling.CustomMarshaller(typeof(Java.JBoolean),global::System.Runtime.InteropServices.Marshalling.MarshalMode.Default,typeof(JBooleanMarshaller))]
    internal static class JBooleanMarshaller;
}

Image

Expected behavior

The .InteropServices should be InteropServices.

Repro steps

I don't know what happened here. Maybe it is because the root namespace only has one depth. Something like ${sub}.InteropServices become the .InteropServices.

Context
  • CsWin32 version: 0.3.269
  • Target Framework: net10.0-windows
  • LangVersion (if explicitly set by project): latest

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with CsWin32RunAsBuildTask enabled and inspect the generated Marshaller and its namespace declarations. Compare the generated .InteropServices namespace with the expected InteropServices namespace, including the JBoolean and JBooleanMarshaller output. Done means the generated namespace is correct for a root namespace with one depth.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.