The P/Invoke `GetWindowThreadProcessId()` doesn't have `SetLastError = true`.
Open
Nobody has claimed this yet.
bug
- Dominant language
- C#
- Stars
- 2.5k
- Forks
- 124
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 9
Description
Actual behavior
This is likely a win32metadata issue, however the documentation for GetWindowThreadProcessId() says: To get extended error information, call GetLastError.
Expected behavior
That this P/Invoke correctly has SetLastError = true.
Repro steps
NativeMethods.txtcontent:
GetWindowThreadProcessId
-
NativeMethods.jsoncontent (if present): N/A -
Any of your own code that should be shared? N/A
Context
- CsWin32 version: 0.3.264
- Win32Metadata version (if explicitly set by project): N/A
- Target Framework: net472
LangVersion(if explicitly set by project): N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the NativeMethods.txt entry for GetWindowThreadProcessId is resolved and how its P/Invoke declaration is generated; the issue suggests the relevant metadata may be in win32metadata. Confirm the generated declaration reflects the Windows documentation by setting SetLastError to true, then verify the generated output or relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- operating-systems, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100