The friendly overload for `AdjustTokenPrivileges()` is inconsistent.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.5k
- Forks
- 124
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 9
Description
Actual behavior
The friendly overload for AdjustTokenPrivileges() requires a pointer to TOKEN_PRIVILEGES for NewState, but uses Span<byte> for PreviousState.
internal static unsafe winmdroot.Foundation.BOOL AdjustTokenPrivileges(SafeHandle TokenHandle, winmdroot.Foundation.BOOL DisableAllPrivileges, winmdroot.Security.TOKEN_PRIVILEGES* NewState, Span<byte> PreviousState, out uint ReturnLength)
{
}
Expected behavior
Consistent parameters for each type. Ideally in winmdroot.Security.TOKEN_PRIVILEGES NewState/out winmdroot.Security.TOKEN_PRIVILEGES* PreviousState.
Repro steps
N/A
NativeMethods.txtcontent:
AdjustTokenPrivileges
-
NativeMethods.jsoncontent (if present):
N/A -
Any of your own code that should be shared?
N/A
Context
- CsWin32 version: 0.3.253
- Win32Metadata version (if explicitly set by project): N/A
- Target Framework: net472
LangVersion(if explicitly set by project): N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the generated declaration from a NativeMethods.txt containing AdjustTokenPrivileges, using the issue's CsWin32 and target framework context. Inspect how the friendly overload is generated and compare the NewState and PreviousState parameter types with the expected consistency; done means the generated signature uses consistent TOKEN_PRIVILEGES representations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100