microsoft / microsoft/CsWin32

Bad setup for `GetCurrentProcess_SafeHandle()`.

Open
#1,411 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

Actual behavior

The wrapper GetCurrentProcess_SafeHandle() returns the current process's handle as a SafeFileHandle. Because the current process's handle is represented as -1, and SafeFileHandle derives itself from SafeHandleZeroOrMinusOneIsInvalid, this means the resulting handle's IsInvalid property is always true.

Expected behavior

The GetCurrentProcess_SafeHandle() wrapper should return a SafeHandle type derived directly from SafeHandle where only 0 is considered invalid.

Repro steps

  1. NativeMethods.txt content:
GetCurrentProcess
  1. NativeMethods.json content (if present):
    N/A

  2. Any of your own code that should be shared?
    N/A

Context
  • CsWin32 version: [0.3.183+73e6125f79.RR]
  • Win32Metadata version (if explicitly set by project): N/A
  • Target Framework: [net462]
  • LangVersion (if explicitly set by project): N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the NativeMethods.txt entry containing GetCurrentProcess and inspect the generated GetCurrentProcess_SafeHandle wrapper. Reproduce the net462 case described in the issue and verify that the returned handle treats the current process handle value as valid, with IsInvalid no longer always true.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.