microsoft / microsoft/CsWin32

Rethink how COM interface Guids are exposed

Open
#1,394 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

Is your feature request related to a problem? Please describe.

I disabled marshalling and every COM definition inherits from IComIID but since IComIID.Guid doesn't have public modifer, I can't access it.

Describe the solution you'd like

Can you add that modifier here?

https://github.com/microsoft/CsWin32/blob/10ff614acb54f6d5a5dbb77c59bd8786e5c99097/src/Microsoft.Windows.CsWin32/Generator.Com.cs#L867-L872

Describe alternatives you've considered

None

Additional context

Also, what's the reason why you added another Guid property (IID_Guid) here (plus the styling looks odd)?

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/Microsoft.Windows.CsWin32/Generator.Com.cs at lines 867-872 and inspect how IComIID.Guid and IID_Guid are declared and exposed. Determine the intended public API and whether the duplicate property is deliberate; done means the requested Guid access is available and the exposure is consistent with the surrounding declarations.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.