microsoft / microsoft/CsWin32

CredUIPromptForCredentials should not emit `ref` on `ref Span<char>` parameter

Open
#1,133 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
2.5k
Forks
124
Avg merge
1d 3h
Merged PRs (30d)
9

Description

The CredUIPromptForCredentials function takes a PWSTR parameter. The friendly overload currently replaces this with ref Span<char> when Span<char> is sufficient, as the friendly overload never rewrites the reference to the span.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the generated friendly overload for CredUIPromptForCredentials and inspect how its PWSTR parameter becomes Span. Compare the emitted declaration with the intended span behavior, then add or update a focused generator test and run the relevant test suite to verify that ref is absent.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.