CreateRestrictedToken should probably return a SafeAccessTokenHandle
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.5k
- Forks
- 124
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 9
Description
We are using CreateRestrictedToken together with WindowsIdentity.RunImpersonatedAsync, but this leads to a problem: WindowsIdentity.RunImpersonatedAsync expects a SafeAccessTokenHandle but CreateRestrictedToken returns a SafeFileHandle.
Would it make sense to change the out parameter of CreateRestrictedToken to SafeAccessTokenHandle?
Thanks in advance!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how CreateRestrictedToken is generated and compare its returned handle type with the SafeAccessTokenHandle required by WindowsIdentity.RunImpersonatedAsync. Check the relevant generator tests, if present, and verify that the generated declaration supports the intended impersonation call without breaking existing uses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100