microsoft / microsoft/Code-Search

SearchDiagnostics/CollectionDbSearchDiagnostics.ps1 log dir is created inside sql script folder

Open
#35 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PowerShell
Stars
57
Forks
68
PR merge metrics
No merged PRs in 30d

Description

Hi.
This is not a bug, but a simple fix to make CollectionDBSearchDiagnostics.ps1 behave like ConfigurationDBSearchDiagnostics.ps1
The first script creates the log folder inside the SQL scripts folder instead of creating it in the root, as the second script does.

https://github.com/Microsoft/Code-Search/blob/3be409ea44ce2a58e5936f6534b4273b0d5b51e4/SearchDiagonistics/CollectionDBSearchDiagnostics.ps1#L20

If the sugestion is accepted and you are busy I could make a PR, since it is quite simple.

Regards

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open SearchDiagonistics/CollectionDBSearchDiagnostics.ps1 at the linked line 20 and compare its log-directory handling with ConfigurationDBSearchDiagnostics.ps1. Confirm that the collection script currently creates the log folder inside the SQL scripts folder; done means it creates the folder in the root as the configuration script does.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.