microsoft / microsoft/CSS-Exchange

[Work Item] Create an additional check to be done for Write Scripts

Open
#1,906 1 comment 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

Work Item
Dominant language
PowerShell
Stars
1.3k
Forks
395
Avg merge
14h 7m
Merged PRs (30d)
5

Description

Describe the work
We want to be able to have a record and accountability for some scripts if they are modified that they should be tested/reviewed when changed. Need to look into a task or something where an additional step is required to be performed in order to allow the PR to be merged.

We are not able to use code owner groups because a modification to a shared script function can modify a write script, thus causing a possible miss for a change that might need additional testing. Plus, then we have a blocker when it comes to actually merging in PRs from internal without an override.

After the script has been determined to be changed, we should create a Work Item that contains detailed steps for repro and things that we need to test out, so it is tracked within this repro. However, we do not need to do this at this time as we only need to do this moving forward when the below scripts have been modified.

Exceptions

  • When it is a format code change. Rules of CSS Exchange to have a similar formatting to be applied. This does not require scripts to be tested and approved.
  • When it is a change to our Exchange Versions function for only adding new version numbers.

Additional Context
These are the following scripts that are determined that need to be tested by a different team other than support if ever changed.

  • Clear-MailboxPermission.ps1
  • CopyMissingDlls.ps1
  • CVE Scripts/EOMT/Test-ProxyLogon (even though proxy logon is not a write script, it is providing a likely hood of vulnerability thus the reason for the need to check)
  • ExchangeExtendedProtectionManagement.ps1
  • FixInstallerCache.ps1
  • Get-EASmailboxLogs.ps1
  • MonitorExchangeAuthCertificate.sp1
  • ReplayQueueDatabases.ps1
  • Reset-ScanEngineVersion.ps1
  • Set-ExchAvExclusions.ps1
  • SetUnifiedContentPath.ps1
  • SetupAssist.ps1 (depends - if high impact recommendation, recommended to have sign off from test team/PG. Local changes to already broken server is okay when not directly making changes to files but a copied version then instructing admin to replace the file after verification.)
  • SourceSideValidations.ps1 (Change on Write scenarios only)
  • Test-AMSI.ps1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.