microsoft / microsoft/CSS-Exchange

[Issue] Invoke-WebRequestWithProxyDetection needs parameter rework

Open
#1,671 0 comments 0 reactions 1 assignee View on GitHub

@lusassl-msft is already working on this.

Since Apr 19, 2023.

Issue Shared Function
Dominant language
PowerShell
Stars
1.3k
Forks
395
Avg merge
14h 7m
Merged PRs (30d)
5

Description

Invoke-WebRequestWithProxyDetection can be called in a simple way by just passing -Uri, or it can be called by passing -ParametersObject with a hashtable. This is weird, because any function can be called by passing a hashtable of parameters already, using splatting. With that approach, we still get the normal parameter handling and validation, instead of bypassing it with -ParametersObject.

Invoke-WebRequestWithProxyDetection should be changed so that all possible parameters are exposed as actual parameters to the function. Then, if you want to pass a hashtable, the user can use splatting to do so.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.