microsoft / microsoft/CLRInstrumentationEngine
Assembly injector needs to convert exception tokens for SEH clauses
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 102
- Forks
- 52
- Avg merge
- 13h 11m
- Merged PRs (30d)
- 6
Description
This seems to be an error - while copying SEH clauses - tokens are only converted and copied for filters, not for regular catch statements:
This causes a failure when you trying to inject an assembly with try{}catch statement into another assembly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/InstrumentationEngine/AssemblyInjector.cpp around lines 713-720, where SEH clauses are copied. Compare the handling of filters with regular catch statements and trace the token conversion path. Done means an assembly containing a try/catch statement can be injected into another assembly without this token-related failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100