microsoft / microsoft/CLRInstrumentationEngine

Leaking dynamically attached instrumentation methods

Open
#34 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
102
Forks
52
Avg merge
13h 11m
Merged PRs (30d)
6

Description

This code unloads dynamically-loaded instrumentation methods:

https://github.com/Microsoft/CLRInstrumentationEngine/blob/0807cc84afec64f95b7fc5350331f1f8c7759efc/src/Extensions.BaseLib/HostExtensionBase.cpp#L328-L339

It seems that references on those instrumentation methods are leaking as destructor is not being called on dynamically loaded instrumentation method

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/Extensions.BaseLib/HostExtensionBase.cpp at lines 328-339, where dynamically loaded instrumentation methods are unloaded. Trace the references held by those methods and the unload path, then verify that their destructors are called and the references no longer leak.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.