microsoft / microsoft/CLRInstrumentationEngine

RawProfilerHook needs both CLR and CoreCLR profiler hooks

Open
#269 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
102
Forks
52
Avg merge
13h 11m
Merged PRs (30d)
6

Description

The RawProfilerHook currently allows for only a configured COR_PROFILER/CORECLR_PROFILER to be chained in. Would be great if a provider could chain in both and the right profiler is picked up at runtime. Figured this out as part of chaining in Microsoft Fakes and Microsoft Code Coverage.

Code Coverage for .NET Core uses its own profiler that sets CORECLR_PROFILER and the module paths. For .NET Framework on the other hand it uses IntelliTrace which sets up COR_PROFILER. If there is a test run that includes both .NET Framework and .NET Core tests, currently both of them would be set.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the RawProfilerHook implementation and how it reads COR_PROFILER and CORECLR_PROFILER. Trace the existing chaining behavior, then verify that a provider can configure both profiler types and that mixed .NET Framework and .NET Core test runs select the appropriate profiler at runtime.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.