microsoft / microsoft/CLRInstrumentationEngine
FileLoggerSink.cpp will fail to create a file if the directory path does not exist.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 102
- Forks
- 52
- Avg merge
- 13h 11m
- Merged PRs (30d)
- 6
Description
FileLoggerSink.cpp uses _fwopen/_fwsopen to create the file. This API will fail if the directory path does not exist.
Consider adding CreateIfNotExist directory check before file open. This has an added benefit of keeping the behavior consistent with our ProductionBreakpoints InstrumentationMethod.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in FileLoggerSink.cpp and inspect how the directory path is handled before _fwopen/_fwsopen. Compare the existing CreateIfNotExist behavior in the ProductionBreakpoints InstrumentationMethod. Done means the required directory exists before the file is opened, while preserving consistent behavior with that instrumentation method.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100