microsoft / microsoft/BuildXL

File opening/creating with Nt/Zw APIs are ignored by sandbox

Open
#680 1 comment 0 reactions 1 assignee View on GitHub

@narasamdya is already working on this.

Since Jul 31, 2019.

help wanted
Dominant language
C#
Stars
1k
Forks
167
PR merge metrics
No merged PRs in 30d

Description

Detoured Win32 APIs handle file opening/creating, but detoured Nt/Zw APIs seem to not handle it. Msys2/Cygwin C runtime implementation use Nt APIs instead of Win32 APIs to implement POSIX functions, which means programs linked to Msys2/Cygwin runtime are not constrained by the sandbox at all.

Any timeline that this can be fixed? I wonder if the change will look similar to how Detoured Win32 implementation? If the change is not too complicated, will the team accept external PR?

https://github.com/microsoft/BuildXL/blob/8621d3e745fb966e4958054da6800230cde8aa38/Public/Src/Sandbox/Windows/DetoursServices/DetouredFunctions.cpp#L5690

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.