microsoft / microsoft/BotFramework-WebChat
Add referrerpolicy="strict-origin-when-cross-origin" to youtube iframes
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Is it an issue related to Adaptive Cards?
No
Is this an accessibility issue?
No
What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
Bundle (webchat.js)
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
Browser: Edge (latest) and maybe more
Which area does this issue affect?
Attachment: Other rich cards
Which theme pack does this issue affect?
I did not test it on other theme packs
What is the public URL for the website?
No response
Please describe the bug
On some browsers youtube iframe links are dead (Error 153). Youtube changed their iframes pretty recently but it seems adding the referrer attribute fixes the problem. It doesn't work for me on Macos edge (but works on chrome firefox and safari).
Do you see any errors in console log?
How to reproduce the issue?
- View a message with a youtube link
What do you expect?
The iframe to not give an error
What actually happened?
The iframe got a 153 error
Do you have any screenshots or recordings to repro the issue?
No response
Adaptive Card JSON
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the issue. Start by locating the code that renders YouTube iframes, reproduce the Edge failure with a message containing a YouTube link, and verify that the requested referrer policy is present and the iframe no longer shows the reported error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100