microsoft / microsoft/BotFramework-WebChat

Warning for sanitize-html dependency

Open
#5,137 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bot Services bug customer-reported
Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Description

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

No response

Which area does this issue affect?

Others or unrelated

What is the public URL for the website?

No response

Please describe the bug

There's a moderate vulnerability on the dependency sanitize-html as detailed at NIST CVE-2024-21501

sanitize-html  <2.12.1
Severity: moderate
sanitize-html Information Exposure vulnerability - https://github.com/advisories/GHSA-rm97-x556-q36h
fix available via `npm audit fix --force`
Will install botframework-webchat@0.15.0, which is a breaking change
node_modules/sanitize-html
  botframework-webchat  >=0.15.1-master.aeca50e
  Depends on vulnerable versions of sanitize-html
  node_modules/botframework-webchat

Can you please bump sanitize-html to the latest version?

Do you see any errors in console log?
sanitize-html  <2.12.1
Severity: moderate
sanitize-html Information Exposure vulnerability - https://github.com/advisories/GHSA-rm97-x556-q36h
fix available via `npm audit fix --force`
Will install botframework-webchat@0.15.0, which is a breaking change
node_modules/sanitize-html
  botframework-webchat  >=0.15.1-master.aeca50e
  Depends on vulnerable versions of sanitize-html
  node_modules/botframework-webchat


### How to reproduce the issue?

1. Navigate to root dir.
2. Run `npm audit fix`


### What do you expect?

I expect there to be no issues when running `npm audit fix`

### What actually happened?

I'm getting a warning when running `npm audit fix`


### Do you have any screenshots or recordings to repro the issue?

_No response_

### Adaptive Card JSON

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the repository root and run the reported npm audit command to confirm the sanitize-html warning and identify where the dependency is declared. Update sanitize-html to a non-vulnerable version, then verify that the audit no longer reports this vulnerability without introducing the stated breaking change.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.