microsoft / microsoft/BotFramework-WebChat

node_modules/micromark-util-decode-numeric-character-reference/index.js 23:11 Module parse failed: Identifier directly after number

Open
#5,006 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bot Services bug customer-reported
Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Description

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

NPM

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

Others or unrelated

Which area does this issue affect?

Development experience

What is the public URL for the website?

No response

Please describe the bug

Started getting this error.
node_modules/micromark-util-decode-numeric-character-reference/index.js 23:11 Module parse failed: Identifier directly after number

Tracked it down to here:
https://github.com/micromark/micromark/issues/161

I feel the attitude of the developers over on Micromark is absolute crap.

I came back to our project, and downgraded your library to version "4.15.9", and everything started compiling fine again.

So apparently, Micromark is some new dependency for you guys?... you might think twice leaning on them based on their attitude to people who are just reporting the issues the library is causing.

Do you see any errors in console log?

No response

How to reproduce the issue?
  1. Include "botframework-webchat": "4.16.0", in your project
  2. Build your project with any version of webpack 4.
  3. Boom! The build blows up in your face.
What do you expect?

I would expect the project to continue to build successfully using your latest version.

What actually happened?

Previously, we had relied on ^ to automatically upgrade your library. It seems your most recent version introduces a requirement (thanks to MicroMark) for WebPack 5. That's a pretty big dependency change and should probably be marked with a major version upgrade.

Do you have any screenshots or recordings to repro the issue?

No response

Adaptive Card JSON

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reported failure at node_modules/micromark-util-decode-numeric-character-reference/index.js:23:11 and reproduce it by installing botframework-webchat 4.16.0 and building with webpack 4. Compare that result with version 4.15.9, then check the linked micromark issue for the dependency change. Done means the latest package builds successfully with webpack 4, or its compatibility requirements are explicitly documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, webpack
Domain
build-system, developer-experience
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.