microsoft / microsoft/BotFramework-WebChat
Confines the citation dialog inside Web Chat
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Is your feature request related to a problem?
Today, the citation dialog is on the top-layer of the page. The huge size allows 5,000 characters of paragraphs to show in the dialog.
However, when the citation is short, it doesn't looks great. Also, when web devs is using IFRAME vs. CDN/NPM of Web Chat, they are not consistent. The dialog in IFRAME is always confined within Web Chat boundary.
Describe the suggestion or request in detail
Let's investigate how to confine the dialog inside Web Chat. One possible way, create a temporary IFRAME to the width/height of Web Chat and put <dialog> inside.
We also need to create a dialog service to unite keyboard help screen and dialog.
Describe alternatives you have considered
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining how the citation dialog and keyboard help screen are implemented in Web Chat, comparing their behavior in an IFRAME and through CDN/NPM usage. Define the dialog boundary and service responsibilities before implementation; done means citations are consistently confined within Web Chat and keyboard help and dialogs share the intended service.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100