microsoft / microsoft/BotFramework-WebChat
Safari: Close button in citation dialog is misaligned
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Is it an issue related to Adaptive Cards?
No
Is this an accessibility issue?
No
What version of Web Chat are you using?
Development build
Which distribution are you using Web Chat from?
Bundle (webchat.js)
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
Browser: Safari (latest), Platform: macOS, Platform: iOS/iPadOS
Which area does this issue affect?
Chat history
What is the public URL for the website?
No response
Please describe the bug
When the citation dialog is opened, the close button keyboard focus ring is not aligned properly.
Do you see any errors in console log?
No response
How to reproduce the issue?
- Talk to MockBot
- Type
citation - Click 3 or 4
What do you expect?
The close button dismiss icon should center-align with the keyboard focus ring.
What actually happened?
The focus ring is misaligned.
Do you have any screenshots or recordings to repro the issue?
Adaptive Card JSON
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the development webchat.js bundle on Safari using MockBot, typing citation, and clicking 3 or 4. Trace the citation dialog's close button and focus ring styling; done means the dismiss icon is centered with the keyboard focus ring on macOS and iOS/iPadOS.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100