microsoft / microsoft/BotFramework-WebChat
Converge `activityMiddleware` and `activityForScreenReaderMiddleware`
Open
Nobody has claimed this yet.
feature-request
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Is your feature request related to a problem?
They are essentially doing same thing. Maybe we should leverage the middleware setup/init/render args to indicate which form of activity we want to render.
Describe the suggestion or request in detail
No response
Describe alternatives you have considered
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating activityMiddleware and activityForScreenReaderMiddleware, then compare how their setup, init, and render arguments are used. Determine how the two activity forms should be selected through those arguments; done means the middleware behavior is converged without losing either rendering form.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100