microsoft / microsoft/BotFramework-WebChat

Upload File - Clicking 'Retry' uploads wrong file

Open
#4,635 9 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

Bot Services bug customer-replied-to customer-reported
Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Description

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

NPM

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

Browser: Edge (latest), Browser: Chrome (latest), Browser: Firefox (latest), Browser: Safari (latest)

Which area does this issue affect?

Send box

What is the public URL for the website?

No response

Please describe the bug

When file upload fails there is an option to retry, clicking retry succeeds but the file that is sent is not the file that was trying to be uploaded.

Do you see any errors in console log?
No
How to reproduce the issue?
  1. Click on the paper clip and upload a file, make sure the file is > than 4MB (you need the the upload to fail)
    The UI will show the file name and size, but because the file is > 4MB the upload will fail (this is fine) the UI will display a Send failed: Retry
  2. Click the Retry button

It will look like the file upload has now completed successfully but this is not true, the file that was uploaded it not the one selected in fact it will be the root web sites html file. This gives a false positive to the user and is very confusing.

What do you expect?

The correct file be upload, appreciate in this scenario the file is too large, which is fine, so perhaps an error message stating the file is to large and remove the ability to retry.

What actually happened?

the wrong file is uploaded

Do you have any screenshots or recordings to repro the issue?

No response

Adaptive Card JSON

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.