microsoft / microsoft/BotFramework-WebChat

Adaptive Card Submit button aria-pressed is changing to true even if Required fields are not fullfilled.

Open
#4,583 0 comments 0 reactions 1 assignee View on GitHub

@compulim is already working on this.

Since Dec 20, 2022.

area-accessibility Bot Services customer-reported ExemptFromDailyDRIReport
Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Description

Hi,
Have functionality in Bot where if user filled all required fields and then click on Submit, changing aria-pressed to true through CSS and disabling that button.

Above scenario is working fine with Webchat Version 4.15.2

In Webchat Version 4.15.2 :-

1.if user is not filling all required fields and pressing Submit Button will show warning on adaptive card.
2.Once user filled all required fields and presses submit button then disabling the submit button.

In Webchat Version 4.15.5 :-

if user is not filling all required fields and pressing Submit button, showing warning on adaptive card but Submit button is getting Disabled (on first click).
even if validations are not finished, aria-pressed to is getting changed to true.

Tried to keep Submit button aria-pressed false all time but then user can click on submit button multiple time and one form will get submitted multiple time or at some point it will cause bot to crash.

Submit button should get disable only after user filled all required fields else, he can click it multiple time, but adaptive card will not get submitted and will show warnings.

Adaptive card version 1.3 is used in it.

Please let me know if there is any way we can resolve this issue in Webchat version 4.15.5.

Thanks.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.