microsoft / microsoft/BotFramework-WebChat
Fully type out `AdaptiveCardsPackage.ts`
Open
Nobody has claimed this yet.
feature-request
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Feature Request
Currently, in packages/bundle/src/types/AdaptiveCardsPackage.ts, we are only re-exporting types that Web Chat is interested.
We should fully export the whole typing for Adaptive Cards package, include Versions which is used by PVA.
type AdaptiveCardsPackage = {
AdaptiveCard: typeof AdaptiveCard;
GlobalSettings: typeof GlobalSettings;
HorizontalAlignment: typeof HorizontalAlignment;
HostConfig: typeof HostConfig;
TextSize: typeof TextSize;
TextWeight: typeof TextWeight;
SerializationContext: typeof SerializationContext;
Version: typeof Version;
};
export default AdaptiveCardsPackage;
[feature-request]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/bundle/src/types/AdaptiveCardsPackage.ts and inspect the current re-exported type surface alongside the Adaptive Cards package exports. Extend the AdaptiveCardsPackage typing to cover the whole package, including Versions used by PVA. Done means the bundle exposes the complete intended Adaptive Cards type surface.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100