microsoft / microsoft/BotFramework-WebChat
Typing for Direct Line objects
Open
Nobody has claimed this yet.
feature-request
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Feature Request
As we start to add typings to all of our code, we specifically didn't type Direct Line objects because we didn't think out the plan to correctly type these objects:
- Import typings from DirectLineJS
- It's outdated
- Import typings from
botframework-schema- It depends on
botbuilder-stdlib, which is not a small library - Some undocumented code is using
botbuilder-stdliband they are related to assertions - We could
import { IActivity } from 'botframework-schema/lib/activityInterfaces'but seems a bit hacky - We could reach SDK team for a further discussion
- It depends on
- Write our owns
- Bigger effort
- We can fully understand what fields we used
- When we move to ACS later, understanding these fields helps
- When we move to ACS, we could consider having our own schema, bringing best of both world
[feature-request]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the three typing approaches listed in the issue: DirectLineJS, botframework-schema, and writing project-owned types. The issue does not name files, tests, or an entry point, and completion is not defined beyond selecting and implementing a typing strategy for Direct Line objects, so clarification is needed before starting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100