microsoft / microsoft/BotFramework-WebChat

Packages don't clean #files allowed list - do at the same time as webpack bump

Open
#3,767 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog bug front-burner p1
Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Description

Version

4.12 RC

Expected behavior

  • package.jsons should use package.json#files to include essential files - should be done in each package.
  • Should also verify .gitignore doesn't need other files added to blocked list.

Additional context

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#files

[Bug]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review each package.json alongside its corresponding .gitignore, then consult the linked npm package.json#files documentation. Compare the files included by each package and verify whether the .gitignore blocked list needs changes while considering the planned webpack bump. Done means every package uses an appropriate files allow list and the package contents are verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.