microsoft / microsoft/BotFramework-WebChat

Modernize styleOptions & separate HTML vs API

Open
#3,720 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog bug front-burner needs-scheduling p1
Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Description

Steps to reproduce

  1. make a change to api/src/defaultStyleOptions, but NOT component/Styles/defaultStyleOptions
  2. View result
  3. make a change to component/Styles/defaultStyleOptions but NOT api/src/defaultStyleOptions,
  4. View result
  5. See behavior is not consistent

Expected behavior

both files should be cleaned up so there are no overlapping styles.

Additional context

This is in prep for RN work, where some styles will not be used in RN.

[Bug]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read api/src/defaultStyleOptions and component/Styles/defaultStyleOptions, then follow the reproduction steps to compare how changes in each file affect behavior. Identify the overlapping styles and separate the HTML and API options so the files are cleaned up and changes no longer produce inconsistent results, while keeping the RN preparation context in mind.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.