microsoft / microsoft/BotFramework-WebChat
[Tracking] DLSpeech: Remove hardcoded audio output format
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Version
master (targeting 4.12.0)
Describe the bug
After we bumped to Speech SDK 1.15.0, there are some bugs that we need to add workaround code.
This tracking bug is for the bug that Speech SDK send us wrong audio output format. When we detect it is MP3 using Direct Line Speech, we hardcoded it to RIFF 16kHz mono.
Steps to reproduce
- Remove the TODO code in
playCognitiveServicesStream.jsby searching this bug number - Talk to the bot through speech
Expected behavior
The bot response should be synthesized at correct sampling rate (16 kHz).
Instead, it synthesized at 24 kHz, which results in a kid-like voice.
Additional context
The workaround should be removed after either 313, or both 313 and 314 is resolved.
https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/313
https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/314 - resolved
[Bug]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open playCognitiveServicesStream.js and search for issue 3692 and its TODO workaround. Reproduce a speech conversation, check that the synthesized response uses the correct 16 kHz sampling rate rather than 24 kHz, and remove the workaround only after Speech SDK issue 313, or both 313 and 314, are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, javascript
- Domain
- audio-video-rtc, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100