microsoft / microsoft/BotFramework-WebChat
Code to-do: move acknowledgement logic to chat adapter
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
(Related to #2490)
Feature Request
In packages/component/src/hooks/internal/useAcknowledgedActivity.js, we have a TODO for moving this acknowledgement logic to chat adapter.
Currently, we assume no chat adapter supports activity acknowledgement. In the future, it may need to change when we support human-to-human conversation.
The current acknowledgement logic:
- Acknowledge all activities when the user explicitly scroll to bottom (from a non-bottom position)
- In the future, we might be able to use
IntersectionObserverto progressively acknowledge activities as the user scroll
- In the future, we might be able to use
- Acknowledge all activities when the user sent a message
There are 3 ways to send the acknowledgement signal:
- Send IDs of activities which is acknowledged (seems too flexible which could make things complicated)
- Send the ID of the last acknowledged activities, everything above that activity is also considered acknowledged
- This assumes the order of activities perceived by Web Chat is same as the chat adapter
- Send a signal to acknowledge all activities
- This assumes the chat adapter know what activities it sent to Web Chat, in an synchronous manner
[feature-request]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/component/src/hooks/internal/useAcknowledgedActivity.js and read the TODO alongside related issue #2490. Document how acknowledgement currently occurs on scrolling and message sending, then resolve which acknowledgement signal the chat adapter should support and define the adapter boundary before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, web-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100