microsoft / microsoft/BotFramework-WebChat
Move user ID into options of DirectLineJS, instead of Web Chat
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Feature Request
"TODO" comment in DirectLineSpeech.js, line 72, states:
// Currently, Web Chat set user ID on all outgoing activities.
// As Direct Line Speech maintains its own user ID, Web Chat should not set the user ID.
// TODO: [P2] We should move user ID into options of DirectLineJS, instead of Web Chat.
Doing so would enable userID accessible and would produce parity with the Direct Line implementation.
Additional context
Related to #3495, Cx is requesting access to both the userID and username properties normally available in renderWebChat.
[Enhancement]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the TODO in packages/directlinespeech/src/DirectLineSpeech.js around line 72, then inspect how DirectLineJS options and Web Chat's renderWebChat userID and username are handled. Compare the Direct Line implementation and related issue #3495; done means userID is available through DirectLineJS options with parity for Direct Line Speech.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100