microsoft / microsoft/BotFramework-WebChat

Import various Web Chat-owned external packages as internal packages

Open
#3,222 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog front-burner needs-team-attention
Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Description

I'm sure I'm missing other packages, so feel free to comment and I will add to the list.

Right now, Web Chat has a multitude of packages that are created by Web Chat developers (exception being 'react-film'), but are not under the team's jurisdiction. They need to be moved into internal packages on Web Chat, the reasons being:

  • One bus problem: if the people that own these packages are no longer on the team, we will no longer have the influence to have the packages updated. Package would need to be moved into our project anyway
  • As personal projects, they are at the bottom of the priority list for fixes or enhancements by the owners
  • Simple feature changes or bug fixes require an entire new layer of Pull Requests, project bumps, etc that are unnecessary and time consuming
  • Web Chat team members are not properly equipped to review new code, approve PRs, or enforce quality of content
    • These are essentially rogue packages that can be updated at any time without having been reviewed by a team member - they show up as invisible package bumps in our project
  • At least one of these packages doesn't have tests, so they are dependent on the Web Chat project for regression control
  • Web Chat devs are responsible for the continued functionality of these components, and therefore are an integral part of the Web Chat project

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inventorying the listed external packages—react-say, react-film, react-scroll-to-bottom, and the adapters—and identify which are owned by Web Chat. Review their tests and dependency usage before planning the migration. Done means the Web Chat-owned packages are internal and their continued functionality has regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
frontend, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.