microsoft / microsoft/BotFramework-WebChat
Using `adaptiveCard.selectAction` instead of `onClick`/`onKeyPress`
Open
Nobody has claimed this yet.
backlog
feature-request
needs-scope
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
In the old days, AC doesn't have JS hook functions.
In the new days, AC has the hook called selectAction. We should migrate over there.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js at line 238 and inspect how the current onClick/onKeyPress hooks are wired. Migrate that interaction to Adaptive Cards' selectAction mechanism, with the old hook usage removed when the migration is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100